almost every car you buy is going to be the worst investment of your life, unless you bought a house at the peak of the market then that would be the exception.
i have never bought a new car, i always buy fixer uppers that were exceptional values when they popped up. the only car i overpaid for was our '95 BMW 318is vert but we also sold it for how much we bought it for. new car sales are going down and used car values are holding decently, it could be worse.
i did buy a brand new KTM dirt bike, which i rarely got to ride. traded it for a 32' enclosed trailer, fixed it up and sold it for $4k(i probably could have gotten $6k if i wasn't in a hurry to sell due to the HOA pressing us to get rid of it) when the bike was only worth $2-2.5k 9 years after i bought it with probably 40 hours on it. you just have to be patient and willing to work for the most out of your investment. the trailer was sitting in a tow lot next to my shop, i asked about it and offered the trade and made it happen(the trailer also saved me thousands in moving expenses), both parties were happy.